Fixes #58 Added updateOptions parameter and deprecate register-as for ember.js 2.0 and later.#59
Open
jakkor wants to merge 3 commits intoicicletech:masterfrom
Open
Fixes #58 Added updateOptions parameter and deprecate register-as for ember.js 2.0 and later.#59jakkor wants to merge 3 commits intoicicletech:masterfrom
jakkor wants to merge 3 commits intoicicletech:masterfrom
Conversation
…ter-as for ember.js 2 In ember.js 2.4 there is no targetObject available and we cannot set it. Instead of this we can now pass an attribute to the component that is observed and when we send to it array of changes it will run those changes on existing Full Calendar element. For ember 2.4 and older we can use register-as, but for ember.js 2.0 to 2.4 there will be a message that this method has been deprecated.
…le when register-as is set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #58 Added updateOptions parameter and deprecate register-as for ember.js 2.0 and later.
In ember.js 2.4 there is no targetObject available and we cannot set it. Instead of this we can now pass an attribute to the component that is observed and when we send to it array of changes it will run those changes on existing Full Calendar element.
For ember 2.4 and older we can use register-as, but for ember.js 2.0 to 2.4 there will be a message that this method has been deprecated.
Version is bumped to 0.1.5.